[Skiboot] [PATCH] hw/imc: Check for pause_microcode_at_boot() return status

Stewart Smith stewart at linux.vnet.ibm.com
Thu Apr 12 15:55:28 AEST 2018


Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
> On Tuesday 10 April 2018 12:06 PM, Stewart Smith wrote:
>> Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
>>> pause_microcode_at_boot() loops through all the chip's ucode
>>> control block and pause the ucode if it is in the running state.
>>> But it does not fail if any of the chip's ucode is not initialised.
>>>
>>> Add code to return a failure if ucode is not initialized in any
>>> of the chip. Since pause_microcode_at_boot() is called just before
>>> attaching the IMC device nodes in imc_init(), add code to check for
>>> the function return.
>>>
>>> Fixes: 9750eee802f8d ('hw/imc: pause microcode at boot')
>>> Signed-off-by: Madhavan Srinivasan <maddy at linux.vnet.ibm.com>
>>> ---
>>>   hw/imc.c | 9 +++++++--
>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>> Should this also go to stable ?
>
> Stewart, yes it should also goto stable.

Okay.

I have no plans for a 5.11.x, but merged to 5.10.x as of:

129e7bc35534  skiboot-5.10.x


-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list