[Skiboot] [PATCH] hw/imc: Check for pause_microcode_at_boot() return status

Madhavan Srinivasan maddy at linux.vnet.ibm.com
Tue Apr 10 18:03:48 AEST 2018



On Tuesday 10 April 2018 12:06 PM, Stewart Smith wrote:
> Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
>> pause_microcode_at_boot() loops through all the chip's ucode
>> control block and pause the ucode if it is in the running state.
>> But it does not fail if any of the chip's ucode is not initialised.
>>
>> Add code to return a failure if ucode is not initialized in any
>> of the chip. Since pause_microcode_at_boot() is called just before
>> attaching the IMC device nodes in imc_init(), add code to check for
>> the function return.
>>
>> Fixes: 9750eee802f8d ('hw/imc: pause microcode at boot')
>> Signed-off-by: Madhavan Srinivasan <maddy at linux.vnet.ibm.com>
>> ---
>>   hw/imc.c | 9 +++++++--
>>   1 file changed, 7 insertions(+), 2 deletions(-)
> Should this also go to stable ?

Stewart, yes it should also goto stable.

Thanks
Maddy

> Merged to master as of afc89188010b4b33c78357eb9af1064690d324cb
>



More information about the Skiboot mailing list