[Skiboot] [PATCH v2 4/9] powerpc/powernv: OPAL console standardise OPAL_BUSY loops
npiggin at gmail.com
Mon Apr 9 16:13:42 AEST 2018
On Mon, 09 Apr 2018 15:53:33 +1000
Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> On Mon, 2018-04-09 at 15:24 +1000, Nicholas Piggin wrote:
> > Convert to using the standard delay poll/delay form.
> > The console code:
> > - Did not previously delay or sleep in its busy loop.
> > Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> > Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> Does it help with anything ? We don't technically *have* to delay or
> wait, I thought it would be good to try to hit the console as fast as
> possible in that case...
We can always make exceptions to the standard form, but in those
cases I would like to document it in the OPAL API and comment for
the Linux side.
My thinking in this case is that it reduces time in firmware and
in particular holding console locks. Is it likely / possible that
we don't have enough buffering or some other issue makes it worth
retrying so quickly?
More information about the Skiboot