[Skiboot] [PATCH v2] hw/slw: Don't assert on a unknown chip

Stewart Smith stewart at linux.ibm.com
Mon Apr 30 17:39:38 AEST 2018

Oliver O'Halloran <oohall at gmail.com> writes:
> For some reason skiboot populates nodes in /cpus/ for the cores on
> chips that are deconfigured. As a result Linux includes the threads
> of those cores in it's set of possible CPUs in the system and attempts
> to set the SPR values that should be used when waking a thread from
> a deep sleep state.
> However, in the case where we have deconfigured chip we don't create
> a xscom node for that chip and as a result we don't have a proc_chip
> structure for that chip either. In turn, this results in an assertion
> failure when calling opal_slw_set_reg() since it expects the chip
> structure to exist. Fix this up and print an error instead.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
> v2: s/c/chip/ I'm raelly smart.
> ---
>  hw/slw.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Thanks, merged to master as of eab215a0bc28dfbc05047b62180313ecdb72c24f
Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list