[Skiboot] [PATCH] xive: fix missing unlock in error path

Stewart Smith stewart at linux.ibm.com
Fri Apr 27 15:59:44 AEST 2018


Found with sparse and some added lock annotations.

Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 hw/xive.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/xive.c b/hw/xive.c
index 3ce19971c4cd..a66f3ff414a0 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -4402,6 +4402,7 @@ static int64_t opal_xive_set_vp_info(uint64_t vp_id,
 				xive_dbg(x, "Attempt at enabling single escalate"
 					 " on xive rev %d failed\n",
 					 x->rev);
+				unlock(&x->lock);
 				return OPAL_PARAMETER;
 			}
 			rc = xive_setup_silent_gather(vp_id, true);
-- 
2.14.3



More information about the Skiboot mailing list