[Skiboot] [PATCH 3/3] device-tree vpd/xscom@: add more VPD to xscom@ nodes

[Stewart Smith]

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> On 04/06/2018 10:46 AM, Stewart Smith wrote:
>> From: Stewart Smith <stewart at linux.vnet.ibm.com>
>> 
>> Notably, add board-info and vendor (if in VPD), which is
>> expected by FWTS and was present on POWER8.
>> 
>> We get properties like:
>> serial-number    "YA1934092546"
>> board-info       "PROCESSOR MODULE"
>
> How did you get this property? I don't  think we are adding this
> property.

It's coming from the VPD, at least on my witherspoon it is.

> Also this patch broke `make check` for me.

Doh, it shouldn't have... I may have to check that then :)

>> part-number      "02AA863"
>> vendor           "IBM             "
>> 
>> This change will also affect what we put in the /vpd hierarchy,
>> but by making it more complete.
>
> AFAIK VINI, VRML and OPFR are mutually exclusive. We should expect either one of 
> these type VPD not mixed one (Of course in some system we are getting mixed 
> one). IMO that's bug in hostboot side of fix.

yeah, we're certainly getting things mixed together in the VPD blobs
that we export in the DT at least. I'm not sure where Hostboot picks
these up from though and if we're really just getting a few things
mashed together.

Oliver/Ananth, by any chance do you know?

-- 
Stewart Smith
OPAL Architect, IBM.