[Skiboot] [PATCH 3/3] device-tree vpd/xscom@: add more VPD to xscom@ nodes

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Sat Apr 7 21:58:41 AEST 2018


On 04/06/2018 10:46 AM, Stewart Smith wrote:
> From: Stewart Smith <stewart at linux.vnet.ibm.com>
> 
> Notably, add board-info and vendor (if in VPD), which is
> expected by FWTS and was present on POWER8.
> 
> We get properties like:
> serial-number    "YA1934092546"
> board-info       "PROCESSOR MODULE"

How did you get this property? I don't  think we are adding this property.

Also this patch broke `make check` for me.

> part-number      "02AA863"
> vendor           "IBM             "
> 
> This change will also affect what we put in the /vpd hierarchy,
> but by making it more complete.

AFAIK VINI, VRML and OPFR are mutually exclusive. We should expect either one of 
these type VPD not mixed one (Of course in some system we are getting mixed 
one). IMO that's bug in hostboot side of fix.

-Vasant



More information about the Skiboot mailing list