[Skiboot] [PATCH] hw/npu2-hw-procedures.c: Update PHY_RESET procedure

[Reza Arbab]

On Fri, Aug 18, 2017 at 02:11:17PM +1000, Alistair Popple wrote:
>Newer versions of Hostboot will have various clocks powered down by default
>to save power. Therefore we need to power them up before accessing the OBUS
>PHY.
>
>Signed-off-by: Alistair Popple <alistair at popple.id.au>
>---
>
>Stewart,
>
>Reza wants to test this before we merge it so best to wait for his
>reviewed/tested-by first. Thanks!

I got confirmation from the lab that this patch eliminates the 
workaround they were using, but I was curious about one thing:

>@@ -252,6 +257,12 @@ static uint32_t phy_reset(struct npu2_dev *ndev)
> {
> 	int lane;
>
>+	/* Power on clocks */
>+	phy_write(ndev, &NPU2_PHY_RX_CLKDIST_PDWN, 0);
>+	phy_write(ndev, &NPU2_PHY_RX_IREF_PDWN, 1);

Shouldn't this one be 0 like the rest?

>+	phy_write(ndev, &NPU2_PHY_TX_CLKDIST_PDWN, 0);
>+	phy_write(ndev, &NPU2_PHY_RX_CTL_DATASM_CLKDIST_PDWN, 0);
>+
> 	FOR_EACH_LANE(ndev, lane)
> 		phy_write_lane(ndev, &NPU2_PHY_RX_RUN_LANE, lane, 0);
>

-- 
Reza Arbab