[PATCH 2/2] Make the diu driver work without board level initilization
Li.Xiubo at freescale.com
Li.Xiubo at freescale.com
Tue Apr 1 13:57:58 EST 2014
> @@ -1752,6 +1793,22 @@ static int fsl_diu_probe(struct platform_device *pdev)
> goto error;
> }
>
> + if (!diu_ops.set_pixel_clock) {
> + data->pixelclk_reg = of_iomap(np, 1);
> + if (!data->pixelclk_reg) {
> + dev_err(&pdev->dev, "Cannot map pixelclk registers, please \
> + provide the diu_ops for pixclk setting instead.\n");
The error message should be in one line if possible, or it will hard to grep.
If cannot, should split it into two or more lines, like:
+ dev_err(&pdev->dev, "Cannot map pixelclk registers,\n"
+ "please provide the diu_ops for pixclk setting instead.\n");
Thanks,
BRs
Xiubo
More information about the Linuxppc-dev
mailing list