[PATCH 2/2] Make the diu driver work without board level initilization
Jason.Jin at freescale.com
Jason.Jin at freescale.com
Tue Apr 1 18:28:28 EST 2014
> > + if (!diu_ops.set_pixel_clock) {
> > + data->pixelclk_reg = of_iomap(np, 1);
> > + if (!data->pixelclk_reg) {
> > + dev_err(&pdev->dev, "Cannot map pixelclk registers,
> please \
> > + provide the diu_ops for pixclk setting
> instead.\n");
>
> The error message should be in one line if possible, or it will hard to
> grep.
> If cannot, should split it into two or more lines, like:
> + dev_err(&pdev->dev, "Cannot map pixelclk registers,\n"
> + "please provide the diu_ops for pixclk setting
> instead.\n");
Thanks, This has been fixed in the update version, please help to review it at:
http://patchwork.ozlabs.org/patch/335225/
I forgot to add the V2 information in the subject in the update patch so this may confuse the reviewer, sorry for that.
Best Regards,
Jason
More information about the Linuxppc-dev
mailing list