[PATCH 4/5] powerpc/fsl-booke: Add initial T208x QDS board support

[Shengzhou.Liu at freescale.com]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, December 18, 2013 3:57 AM
> To: Liu Shengzhou-B36685
> Cc: linuxppc-dev at lists.ozlabs.org
> Subject: Re: [PATCH 4/5] powerpc/fsl-booke: Add initial T208x QDS board
> support
> 
> On Wed, 2013-12-11 at 19:19 +0800, Shengzhou Liu wrote:
> > +		boardctrl: board-control at 3,0 {
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > +			compatible = "fsl,fpga-qixis";
> > +			reg = <3 0 0x300>;
> > +			ranges = <0 3 0 0x300>;
> > +		};
> 
> Why do you have ranges and #address-cells/#size-cells here?  When would
> there ever be a child node?

[Shengzhou] There are multiple child nodes for this(in a separate DPAA-related patch, but whole DPAA module has not been upstreamed yet so far)

> 
> > +	};
> > +
> > +	memory {
> > +		device_type = "memory";
> > +	};
> > +
> > +	dcsr: dcsr at f00000000 {
> > +		ranges = <0x00000000 0xf 0x00000000 0x01072000>;
> > +	};
> > +
> > +	soc: soc at ffe000000 {
> > +		ranges = <0x00000000 0xf 0xfe000000 0x1000000>;
> > +		reg = <0xf 0xfe000000 0 0x00001000>;
> > +		spi at 110000 {
> > +			flash at 0 {
> > +				#address-cells = <1>;
> > +				#size-cells = <1>;
> > +				compatible = "spansion,s25sl12801";
> > +				reg = <0>;
> > +				spi-max-frequency = <40000000>; /* input clock */
> > +				partition at u-boot {
> > +					label = "SPI U-Boot";
> > +					reg = <0x00000000 0x00100000>;
> > +					read-only;
> > +				};
> > +				partition at kernel {
> > +					label = "SPI Kernel";
> > +					reg = <0x00100000 0x00500000>;
> > +					read-only;
> > +				};
> > +				partition at dtb {
> > +					label = "SPI DTB";
> > +					reg = <0x00600000 0x00100000>;
> > +					read-only;
> > +				};
> > +				partition at fs {
> > +					label = "SPI File System";
> > +					reg = <0x00700000 0x00900000>;
> > +				};
> 
> These are not valid unit addresses -- and the kernel/dtb should not be read-only.  
> Do you really want to dedicate a whole mebibyte to the dtb, given that
> the flash is only 16 MiB total?
> 
> Actually, let's please just stop putting partitions in the dts.  Either
> use mtdparts on the command line, or have U-Boot fill in the partition
> info (there is code in U-Boot to do this based on the mtdparts env
> variable).
> 
 
[Shengzhou] okay, will use mtdparts instead of this way.