[PATCH 4/5] powerpc/fsl-booke: Add initial T208x QDS board support

Scott Wood scottwood at freescale.com
Sat Dec 28 09:53:59 EST 2013


On Fri, 2013-12-20 at 00:42 -0600, Liu Shengzhou-B36685 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, December 18, 2013 3:57 AM
> > To: Liu Shengzhou-B36685
> > Cc: linuxppc-dev at lists.ozlabs.org
> > Subject: Re: [PATCH 4/5] powerpc/fsl-booke: Add initial T208x QDS board
> > support
> > 
> > On Wed, 2013-12-11 at 19:19 +0800, Shengzhou Liu wrote:
> > > +		boardctrl: board-control at 3,0 {
> > > +			#address-cells = <1>;
> > > +			#size-cells = <1>;
> > > +			compatible = "fsl,fpga-qixis";
> > > +			reg = <3 0 0x300>;
> > > +			ranges = <0 3 0 0x300>;
> > > +		};
> > 
> > Why do you have ranges and #address-cells/#size-cells here?  When would
> > there ever be a child node?
> 
> [Shengzhou] There are multiple child nodes for this(in a separate DPAA-related patch, but whole DPAA module has not been upstreamed yet so far)

Those properties can be added if and when the dpaa nodes go upstream.
They don't make sense as is.

-Scott




More information about the Linuxppc-dev mailing list