[PATCH 4/5] powerpc/fsl-booke: Add initial T208x QDS board support

[Scott Wood]

On Wed, 2013-12-11 at 19:19 +0800, Shengzhou Liu wrote:
> +		boardctrl: board-control at 3,0 {
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			compatible = "fsl,fpga-qixis";
> +			reg = <3 0 0x300>;
> +			ranges = <0 3 0 0x300>;
> +		};

Why do you have ranges and #address-cells/#size-cells here?  When would
there ever be a child node?

> +	};
> +
> +	memory {
> +		device_type = "memory";
> +	};
> +
> +	dcsr: dcsr at f00000000 {
> +		ranges = <0x00000000 0xf 0x00000000 0x01072000>;
> +	};
> +
> +	soc: soc at ffe000000 {
> +		ranges = <0x00000000 0xf 0xfe000000 0x1000000>;
> +		reg = <0xf 0xfe000000 0 0x00001000>;
> +		spi at 110000 {
> +			flash at 0 {
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				compatible = "spansion,s25sl12801";
> +				reg = <0>;
> +				spi-max-frequency = <40000000>; /* input clock */
> +				partition at u-boot {
> +					label = "SPI U-Boot";
> +					reg = <0x00000000 0x00100000>;
> +					read-only;
> +				};
> +				partition at kernel {
> +					label = "SPI Kernel";
> +					reg = <0x00100000 0x00500000>;
> +					read-only;
> +				};
> +				partition at dtb {
> +					label = "SPI DTB";
> +					reg = <0x00600000 0x00100000>;
> +					read-only;
> +				};
> +				partition at fs {
> +					label = "SPI File System";
> +					reg = <0x00700000 0x00900000>;
> +				};

These are not valid unit addresses -- and the kernel/dtb should not be
read-only.  Please consider fixing where you copied this from, as well.

Do you really want to dedicate a whole mebibyte to the dtb, given that
the flash is only 16 MiB total?

Actually, let's please just stop putting partitions in the dts.  Either
use mtdparts on the command line, or have U-Boot fill in the partition
info (there is code in U-Boot to do this based on the mtdparts env
variable).

> diff --git a/arch/powerpc/include/asm/mpc85xx.h b/arch/powerpc/include/asm/mpc85xx.h
> index 736d4ac..3bef74a 100644
> --- a/arch/powerpc/include/asm/mpc85xx.h
> +++ b/arch/powerpc/include/asm/mpc85xx.h
> @@ -77,6 +77,8 @@
>  #define SVR_T1020	0x852100
>  #define SVR_T1021	0x852101
>  #define SVR_T1022	0x852102
> +#define SVR_T2080	0x853000
> +#define SVR_T2081	0x853100
>  
>  #define SVR_8610	0x80A000
>  #define SVR_8641	0x809000

Why is this in the board device tree patch?

-Scott