[RFC/PATCH 1/2] [POWERPC] mpc5200: normalize compatible property bindings

[Stephen Rothwell]

Hi Grant,

On Fri, 18 Jan 2008 10:04:49 -0700 Grant Likely <grant.likely at secretlab.ca> wrote:
>
> +++ b/arch/powerpc/platforms/52xx/lite5200.c
> @@ -44,9 +44,14 @@ lite5200_fix_clock_config(void)
>  {
>  	struct device_node *np;
>  	struct mpc52xx_cdm  __iomem *cdm;
> +	struct of_device_id cdm_ids[] = {

Surely this should be static and __initdata?

> @@ -79,9 +84,14 @@ lite5200_fix_port_config(void)
>  {
>  	struct device_node *np;
>  	struct mpc52xx_gpio __iomem *gpio;
> +	struct of_device_id gpio_ids[] = {

And this?

> +++ b/arch/powerpc/platforms/52xx/lite5200_pm.c
> @@ -43,6 +43,12 @@ static int lite5200_pm_set_target(suspend_state_t state)
>  static int lite5200_pm_prepare(void)
>  {
>  	struct device_node *np;
> +	struct of_device_id immr_ids[] = {

This should be static and const.

Similarly for the rest ...

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080119/bf9fe726/attachment.pgp>