[rtc-linux] [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500
Linus Walleij
linus.walleij at linaro.org
Thu Aug 9 00:28:24 EST 2012
On Wed, Aug 8, 2012 at 11:19 AM, Arnd Bergmann <arnd at arndb.de> wrote:
>> What on earth are all those magic numbers?
>>
>> I *guess* they're enabling some default GPIO settings etc.
>
> No, they are the register offsets you quoted above, per bank.
Aha I was fooled by this:
+struct vt8500_gpio_bank_regs {
+ int en;
+ int dir;
+ int data_out;
+ int data_in;
+ int ngpio;
+};
This needs to be named something intuitive like "vt8500_gpio_bank_regoffsets"
Some kerneldoc intsead of the opaque comment above will also improve
readability a lot:
/**
* struct vt8500_gpio_bank_regoffsets
* @en: offset to enable register in the bank
* ...
Yours,
Linus Walleij
More information about the devicetree-discuss
mailing list