[PATCH v3 0/3] Add DT support to C_CAN/D_CAN controller

[Marc Kleine-Budde]

On 08/02/2012 01:39 PM, AnilKumar, Chimata wrote:
[...]
>>>>> AnilKumar Ch (3):
>>>>>   can: c_can: Add device tree support to Bosch C_CAN/D_CAN controller
>>>>>   can: c_can: Modify c_can device names in c_can_pci driver
>>>>
>>>> You break bisectability here. After patch 1 the pci driver will not
>>>> compile anymore. I suggest to do the renaming of enum c_can_dev_id and
>>>> all it's users in patch 1.
>>>>
>>>
>>> I will merge patch 1 and 2 and submit v4.
>>
>> But changing the pci driver has nothing to do with the subject ("Add
>> device tree support to Bosch C_CAN/D_CAN controller").
>>
>> It's considered bad practise to do so.
>>
> 
> In that case I will change the patch 1 according to "C_CAN_PLTFORM_DEVTYPE"
> and flag name changes to BOSCH_* will be in patch 2. So that we can get rid
> of these two problems.

I'm not sure if I understand you correctly. Please first rename the
constants, then add device tree support.

It doesn't make any sense to first introduce DT support and then patch
parts of the DT that have been added in the previous patch.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20120802/2a21df16/attachment.sig>