[SLOF] [PATCH] pci: Translate PCI addresses to host addresses at the end of map-in

Thomas Huth thuth at redhat.com
Thu Jul 20 17:33:25 AEST 2017


On 20.07.2017 08:46, Alexey Kardashevskiy wrote:
> On 13/07/17 23:07, Thomas Huth wrote:
>> Currently, it is not possible to use VGA devices attached to a
>> PCI bridge on board-qemu, e.g. by starting QEMU like this:
>>
>>  qemu-system-ppc64 -nodefaults -device pci-bridge,id=br1,chassis_nr=1 \
>>         -serial mon:stdio -device VGA,id=video,bus=br1,addr=1
>>
>> One of the problems is the missing translate-address at the end
>> of the map-in function of the bridge - which was already marked
>> as a TODO, but apparently has never been enabled. So let's do
>> that now!
>>
> 
> Thanks, applied.
> 
> I wonder why did you do that at the time when you put that "TODO" comment? :)

I think I did not write that part of the code ... but IIRC the PCI code
was written before we had the translate-address function in a usable
shape, so the TODO comment was all that could have been done at that
point in time. Later we likely forgot about it since it was not
necessary on JS2x.

 Thomas


More information about the SLOF mailing list