[SLOF] [PATCH] pci: Translate PCI addresses to host addresses at the end of map-in

[Alexey Kardashevskiy]

On 13/07/17 23:07, Thomas Huth wrote:
> Currently, it is not possible to use VGA devices attached to a
> PCI bridge on board-qemu, e.g. by starting QEMU like this:
> 
>  qemu-system-ppc64 -nodefaults -device pci-bridge,id=br1,chassis_nr=1 \
>         -serial mon:stdio -device VGA,id=video,bus=br1,addr=1
> 
> One of the problems is the missing translate-address at the end
> of the map-in function of the bridge - which was already marked
> as a TODO, but apparently has never been enabled. So let's do
> that now!
> 

Thanks, applied.

I wonder why did you do that at the time when you put that "TODO" comment? :)


> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
>  slof/fs/pci-config-bridge.fs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/slof/fs/pci-config-bridge.fs b/slof/fs/pci-config-bridge.fs
> index 1efbcd8..4169aa8 100644
> --- a/slof/fs/pci-config-bridge.fs
> +++ b/slof/fs/pci-config-bridge.fs
> @@ -73,7 +73,7 @@
>        nip
>     THEN
>     F NOT AND                            \ Clear indicator bits
> -   \ TODO: Use translate-address here!
> +   translate-my-address
>  ;
>  
>  : map-out ( virt size -- )
> 


-- 
Alexey