[SLOF] [PATCH] pci: Translate PCI addresses to host addresses at the end of map-in

[Thomas Huth]

On 20.07.2017 09:56, Alexey Kardashevskiy wrote:
> On 20/07/17 17:33, Thomas Huth wrote:
>> On 20.07.2017 08:46, Alexey Kardashevskiy wrote:
>>> On 13/07/17 23:07, Thomas Huth wrote:
>>>> Currently, it is not possible to use VGA devices attached to a
>>>> PCI bridge on board-qemu, e.g. by starting QEMU like this:
>>>>
>>>>  qemu-system-ppc64 -nodefaults -device pci-bridge,id=br1,chassis_nr=1 \
>>>>         -serial mon:stdio -device VGA,id=video,bus=br1,addr=1
>>>>
>>>> One of the problems is the missing translate-address at the end
>>>> of the map-in function of the bridge - which was already marked
>>>> as a TODO, but apparently has never been enabled. So let's do
>>>> that now!
>>>>
>>>
>>> Thanks, applied.
>>>
>>> I wonder why did you do that at the time when you put that "TODO" comment? :)
>>
>> I think I did not write that part of the code ...
> 
> https://github.com/aik/SLOF/commit/de5b143a ;)
> 
>> but IIRC the PCI code
>> was written before we had the translate-address function in a usable
>> shape,
> 
> slof/fs/translate.fs's translate-address is there since the initial commit ;)

Ooops, looks like my memory completely failed here. It's true that the
PCI code has been originally written before translate-address had been
implemented, but seems like I completely forgot about that map-in patch
that I added there later, sorry! Not sure why I did not use
translate-address here right from the start - maybe simply because it
was just not necessary on JS2x - or maybe because there are some other
bugs left in the JS2x code that caused trouble here ... hard to tell
without having a way to test the JS2x ATI code again...

 Thomas