[SLOF] [PATCH] pci: Translate PCI addresses to host addresses at the end of map-in

Thomas Huth thuth at redhat.com
Mon Jul 17 21:17:16 AEST 2017


On 17.07.2017 12:16, Thomas Huth wrote:
> On 13.07.2017 15:07, Thomas Huth wrote:
[...]
>> diff --git a/slof/fs/pci-config-bridge.fs b/slof/fs/pci-config-bridge.fs
>> index 1efbcd8..4169aa8 100644
>> --- a/slof/fs/pci-config-bridge.fs
>> +++ b/slof/fs/pci-config-bridge.fs
>> @@ -73,7 +73,7 @@
>>        nip
>>     THEN
>>     F NOT AND                            \ Clear indicator bits
>> -   \ TODO: Use translate-address here!
>> +   translate-my-address
>>  ;
> 
> Looking at my patch again, I think it is cleaner if I do a "my-phandle
> swap translate-address" here ... so please ignore this version, I'll
> send a v2 instead.

Ah, well, please ignore my "please ignore" message above ;-)
Looks like "my-phandle" does not work here - since it is set to the
bridge and not to the device here. So "translate-my-address" is the
right thing to do here and the above version of my patch is fine.

 Thomas


More information about the SLOF mailing list