[Skiboot] [PATCH v2] opal-gard: sync up the chip unit data list with upstream hostboot.

[Dan Horák]

On Tue, 26 May 2020 10:22:22 +0530
Mahesh Salgaonkar <mahesh at linux.ibm.com> wrote:

> opal-gard on POWER9P system fails to identify few chip targets while
> displaying gard records. This patch fixes that.

LGTM, the ids match the ones from obj/genfiles/errl/errludtarget.H

Reviewed-by: Dan Horák <dan at danny.cz>


		Dan

 
> Before:
> # opal-gard list
>  ID       | Error    | Type       | Path
> -------------------------------------------------------------------------------
>  00000001 | 90004af4 | Predictive
> | /Sys0/Node0/Proc0/MC0/MI0/UNKNOWN0/UNKNOWN0
> | ===============================================================================
> 
> After this patch:
> # ./opal-gard list
>  ID       | Error    | Type       | Path
> ---------------------------------------------------------------------------
>  00000001 | 90004af4 | Predictive
> | /Sys0/Node0/Proc0/MC0/MI0/MCC0/OMI0
> | ===========================================================================
> 
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.ibm.com>
> ---
> Change in v2:
> - Fixed typo in subject line.
> ---
>  external/gard/units.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/external/gard/units.c b/external/gard/units.c
> index 677d68f5b..35d46e443 100644
> --- a/external/gard/units.c
> +++ b/external/gard/units.c
> @@ -140,6 +140,14 @@ const struct chip_unit_desc p9_chip_units[] = {
>  	{0x44, "MC"},
>  	{0x45, "TEST_FAIL"},
>  	{0x46, "MFREFCLK"},
> -	{0x47, "LAST_IN_RANGE"},
> +	{0x47, "SMPGROUP"},
> +	{0x48, "OMI"},
> +	{0x49, "MCC"},
> +	{0x4A, "OMIC"},
> +	{0x4B, "OCMB_CHIP"},
> +	{0x4C, "MEM_PORT"},
> +	{0x4D, "I2C_MUX"},
> +	{0x4E, "PMIC"},
> +	{0x4F, "LAST_IN_RANGE"},
>  };
>  
> 
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot