[Skiboot] [PATCH] hw/phys-map: Fix OCAPI_MEM BAR values
oohall at gmail.com
Tue May 26 17:02:02 AEST 2020
On Wed, Apr 15, 2020 at 5:32 PM Andrew Donnellan <ajd at linux.ibm.com> wrote:
> The comment next to the OCAPI_MEM entries in the Nimbus phys-map claims
> that we are "varying the upper 2 bits of the group ID" for each OpenCAPI
> link, as matches the chip address extension mask that will be set by future
> versions of Hostboot.
> The actual entries, on the other hand, vary the *lower* 2 bits of the group
> ID. Whoops.
> This didn't appear to cause us problems on the specific machines that we
> had access to at the time, but now that this is being tested a bit harder
> it's crashing machines...
> Fixes: bc72973d13215 ("hw/npu2-opencapi: Support multiple LPC devices")
> Cc: Frederic Barrat <fbarrat at linux.ibm.com>
> Reported-by: Wael El-Essawy <welessa at us.ibm.com>
> Reported-by: Milton Miller <miltonm at us.ibm.com>
> Reported-by: Jenny Huynh <jhuynh at us.ibm.com>
> Signed-off-by: Andrew Donnellan <ajd at linux.ibm.com>
Thanks, merged as 75198f668911830bb5df27da59786199eac2e47c
More information about the Skiboot