[Skiboot] [PATCH 09/51] libflash/ipmi-hiomap: Improve BMC error state behaviour

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Feb 22 17:21:54 AEDT 2019

On 02/15/2019 12:26 PM, Andrew Jeffery wrote:
> impi_hiomap_handle_events()'s implementation contained an early-exit
> that was only valid for handling ackable events, but the state provided
> in the BMC's notification contains non-ackable state as well. Remove the
> early exit to ensure we don't attempt to proceed with requests that we
> know will fail which occur after an initial request has cleared the
> ackable bits (but failed to restore the window state).
> Include a test case to capture the desired behaviour.
> Cc: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>

Looks good to me. It fixes the issue I was talking earlier.

Tested-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

   We should pick this for stable #v6.0.x +


More information about the Skiboot mailing list