[Skiboot] [PATCH 09/51] libflash/ipmi-hiomap: Improve BMC error state behaviour

Stewart Smith stewart at linux.ibm.com
Mon Feb 18 12:06:40 AEDT 2019


Andrew Jeffery <andrew at aj.id.au> writes:
> impi_hiomap_handle_events()'s implementation contained an early-exit
> that was only valid for handling ackable events, but the state provided
> in the BMC's notification contains non-ackable state as well. Remove the
> early exit to ensure we don't attempt to proceed with requests that we
> know will fail which occur after an initial request has cleared the
> ackable bits (but failed to restore the window state).
>
> Include a test case to capture the desired behaviour.
>
> Cc: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>

Also cc stable?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list