[Skiboot] [PATCH 09/51] libflash/ipmi-hiomap: Improve BMC error state behaviour

[Andrew Jeffery]

On Fri, 22 Feb 2019, at 16:52, Vasant Hegde wrote:
> On 02/15/2019 12:26 PM, Andrew Jeffery wrote:
> > impi_hiomap_handle_events()'s implementation contained an early-exit
> > that was only valid for handling ackable events, but the state provided
> > in the BMC's notification contains non-ackable state as well. Remove the
> > early exit to ensure we don't attempt to proceed with requests that we
> > know will fail which occur after an initial request has cleared the
> > ackable bits (but failed to restore the window state).
> > 
> > Include a test case to capture the desired behaviour.
> > 
> > Cc: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> 
> Looks good to me. It fixes the issue I was talking earlier.
> 
> Tested-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

Note that there's a v2 of the series on the list (though I see you found that,
and it's also already been merged).

Andrew

> 
> @Stewart,
>    We should pick this for stable #v6.0.x +
> 
> -Vasant
> 
>