[Skiboot] [PATCH] hdata: Fix dtc warnings

[Oliver]

On Sat, Jun 23, 2018 at 4:48 PM, Vasant Hegde
<hegdevasant at linux.vnet.ibm.com> wrote:
> Fix dtc warnings related to mcbist node.
>
> Warning (reg_format): "reg" property in /xscom at 623fc00000000/mcbist at 1 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
> Warning (reg_format): "reg" property in /xscom at 623fc00000000/mcbist at 2 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
> Warning (reg_format): "reg" property in /xscom at 603fc00000000/mcbist at 1 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
> Warning (reg_format): "reg" property in /xscom at 603fc00000000/mcbist at 2 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
>
> Ideally we should add proper xscom range here... but we are not getting that
> information in HDAT today. Lets fix warning until we get proper data in HDAT.

The HDAT spec seems to use "MCBIST" to mean MC chiplet, so you could
use the base address of each chiplet rather than making one up. I did
some digging and found that:

MC01 (mcbist0) is at 0x7000000
MC23 (mcbist1) is at 0x8000000

That said our hierarchy doesn't make a whole lot of sense since the
MCSes are part of the nest chiplets rather than the MC chiplets. What
actually consumes this data? Does it care about the exact hierarchy or
does it just look at the dimm@ nodes at the bottom?

> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>  hdata/memory.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hdata/memory.c b/hdata/memory.c
> index c0c30066e..578479fe1 100644
> --- a/hdata/memory.c
> +++ b/hdata/memory.c
> @@ -450,7 +450,9 @@ static void add_memory_controller(const struct HDIF_common_hdr *msarea,
>         if (!mcbist) {
>                 mcbist = dt_new_addr(xscom, "mcbist", mcbist_id);
>                 assert(mcbist);
> -               dt_add_mem_reg_property(mcbist, mcbist_id);
> +               dt_add_property_cells(mcbist, "#address-cells", 1);
> +               dt_add_property_cells(mcbist, "#size-cells", 0);
> +               dt_add_property_cells(mcbist, "reg", mcbist_id, 0);
>         }
>
>         mcs_id = MS_CONTROLLER_MCS_ID(controller_id);
> --
> 2.14.3
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot