[Skiboot] [PATCH] hdata: Fix dtc warnings

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Sat Jun 23 16:48:09 AEST 2018


Fix dtc warnings related to mcbist node.

Warning (reg_format): "reg" property in /xscom at 623fc00000000/mcbist at 1 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Warning (reg_format): "reg" property in /xscom at 623fc00000000/mcbist at 2 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Warning (reg_format): "reg" property in /xscom at 603fc00000000/mcbist at 1 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Warning (reg_format): "reg" property in /xscom at 603fc00000000/mcbist at 2 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)

Ideally we should add proper xscom range here... but we are not getting that
information in HDAT today. Lets fix warning until we get proper data in HDAT.

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hdata/memory.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hdata/memory.c b/hdata/memory.c
index c0c30066e..578479fe1 100644
--- a/hdata/memory.c
+++ b/hdata/memory.c
@@ -450,7 +450,9 @@ static void add_memory_controller(const struct HDIF_common_hdr *msarea,
 	if (!mcbist) {
 		mcbist = dt_new_addr(xscom, "mcbist", mcbist_id);
 		assert(mcbist);
-		dt_add_mem_reg_property(mcbist, mcbist_id);
+		dt_add_property_cells(mcbist, "#address-cells", 1);
+		dt_add_property_cells(mcbist, "#size-cells", 0);
+		dt_add_property_cells(mcbist, "reg", mcbist_id, 0);
 	}
 
 	mcs_id = MS_CONTROLLER_MCS_ID(controller_id);
-- 
2.14.3



More information about the Skiboot mailing list