[Skiboot] [PATCH 1/2] hw/npu2: Implement logging HMI actions

[Alistair Popple]

On Tuesday, 20 February 2018 3:15:36 PM AEDT Michael Ellerman wrote:
> Balbir Singh <bsingharora at gmail.com> writes:
> 
> > diff --git a/include/opal-api.h b/include/opal-api.h
> > index e0580891..86a6103d 100644
> > --- a/include/opal-api.h
> > +++ b/include/opal-api.h
> > @@ -725,6 +725,104 @@ enum OpalHMI_NestAccelXstopReason {
> >  	NX_CHECKSTOP_PBI_ISN_UE			= 0x00002000,
> >  };
> >  
> > +/*
> > + * Can't use enums for 64 bit values, use #defines
> > + */
> > +#define NPU2_CHECKSTOP_REG0_NTL_ARRAY_CE		PPC_BIT(0)
> 
> Snip ~90 more NPU2_CHECKSTOP #defines.
> 
> You've put these in opal-api.h, which means they're part of the OPAL API
> for all time, is that really what we wanted?

I don't think so, at least not if these are the actual register bits as their
definition has changed between DD levels let alone whole chip revisions.

- Alistair

> cheers
>