[Skiboot] [PATCH 1/2] hw/npu2: Implement logging HMI actions

[Stewart Smith]

Michael Ellerman <mpe at ellerman.id.au> writes:
> Balbir Singh <bsingharora at gmail.com> writes:
>
>> diff --git a/include/opal-api.h b/include/opal-api.h
>> index e0580891..86a6103d 100644
>> --- a/include/opal-api.h
>> +++ b/include/opal-api.h
>> @@ -725,6 +725,104 @@ enum OpalHMI_NestAccelXstopReason {
>>  	NX_CHECKSTOP_PBI_ISN_UE			= 0x00002000,
>>  };
>>  
>> +/*
>> + * Can't use enums for 64 bit values, use #defines
>> + */
>> +#define NPU2_CHECKSTOP_REG0_NTL_ARRAY_CE		PPC_BIT(0)
>
> Snip ~90 more NPU2_CHECKSTOP #defines.
>
> You've put these in opal-api.h, which means they're part of the OPAL API
> for all time, is that really what we wanted?

it's not.

I noticed this the other day, and it turns out that when I merged it I
missed which file it went into.

I'll move them.

-- 
Stewart Smith
OPAL Architect, IBM.