[Skiboot] [PATCH 1/2] hw/npu2: Implement logging HMI actions

Michael Ellerman mpe at ellerman.id.au
Tue Feb 20 15:15:36 AEDT 2018


Balbir Singh <bsingharora at gmail.com> writes:

> diff --git a/include/opal-api.h b/include/opal-api.h
> index e0580891..86a6103d 100644
> --- a/include/opal-api.h
> +++ b/include/opal-api.h
> @@ -725,6 +725,104 @@ enum OpalHMI_NestAccelXstopReason {
>  	NX_CHECKSTOP_PBI_ISN_UE			= 0x00002000,
>  };
>  
> +/*
> + * Can't use enums for 64 bit values, use #defines
> + */
> +#define NPU2_CHECKSTOP_REG0_NTL_ARRAY_CE		PPC_BIT(0)

Snip ~90 more NPU2_CHECKSTOP #defines.

You've put these in opal-api.h, which means they're part of the OPAL API
for all time, is that really what we wanted?

cheers


More information about the Skiboot mailing list