[Skiboot] [PATCH 1/3] pci-dt-slot: Big ol' cleanup

Stewart Smith stewart at linux.ibm.com
Tue Apr 24 13:34:52 AEST 2018

Oliver O'Halloran <oohall at gmail.com> writes:
> The underlying data that we get from HDAT can only really describe a
> PCIe system. As such we can simplify the devicetree slot lookup code
> by only caring about the important cases, namly, root ports and switch
> downstream ports.
> This also fixes a bug where root port didn't get a Slot label applied
> which results in devices under that port not having ibm,loc-code set.
> This results in the EEH core being unable to report the location of
> EEHed devices under that port.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  core/pci-dt-slot.c | 154 +++++++++++++++++++++++++----------------------------
>  1 file changed, 74 insertions(+), 80 deletions(-)

With a bit of YOLO combined with being relatively sure you got it right
and a *very* light look over the code, merged to master as of

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list