[Skiboot] [PATCH] phb4: Minor CAPP init cleanup

Michael Neuling mikey at neuling.org
Mon Apr 23 15:41:02 AEST 2018


Currently we RMW the TRANSPORT_CONTROL register and then RMW it again
for no good reason. Make this a single RMW.

Signed-off-by: Michael Neuling <mikey at neuling.org>
---
 hw/phb4.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hw/phb4.c b/hw/phb4.c
index 50e1be1c4c..134d1747b5 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -3756,10 +3756,7 @@ static void phb4_init_capp_regs(struct phb4 *p, uint32_t capp_eng)
 			reg |= PPC_BIT(60);
 		}
 	}
-	xscom_write(p->chip_id, TRANSPORT_CONTROL + offset, reg);
-
 	/* Initialize CI Store Buffers */
-	xscom_read(p->chip_id, TRANSPORT_CONTROL + offset, &reg);
 	reg |= PPC_BIT(63);
 	xscom_write(p->chip_id, TRANSPORT_CONTROL + offset, reg);
 
-- 
2.14.1



More information about the Skiboot mailing list