[Skiboot] [PATCH v8 2/2] Add SBE driver support

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Sun Apr 22 22:09:52 AEST 2018

On 04/21/2018 06:57 AM, Benjamin Herrenschmidt wrote:
> On Fri, 2018-04-20 at 12:20 +0530, Vasant Hegde wrote:
>>> Generally I still prefer if we handle one bit at a time amd loop & re-
>>> read & retry, as discussed.
>> I thought about that.. But I don't see much benefits. In both cases we have to
>> take care of
>> ordering (like process ACK before response). And we will end up clearing each
>> bit separately. So we will do additional xscom_write to clear bits.
>> If you really want that method I can change the code. Please let me know.
> The worry is that we may complete the message before we've processed
> all the bits, thus dropping the lock, allowing new messages in and
> possibly other opetations to happen. It might be ok, but ...

May be this will simply things as we just need to worry about processing one bit 
a time and make sure sbe state is fine wrt to that message.

Let me rework the code. Lets see how it goes.


More information about the Skiboot mailing list