[Skiboot] [PATCH] hw/npu2.c: Remove static configuration of NPU2 register

Stewart Smith stewart at linux.ibm.com
Fri Apr 20 17:25:33 AEST 2018

Alistair Popple <alistair at popple.id.au> writes:
> The NPU_SM_CONFIG0 register currently needs to be configured in Skiboot to
> select NVLink mode, however Hostboot should configure other bits in this
> register.
> For some reason Skiboot was explicitly clearing bit-6
> (CONFIG_DISABLE_VG_NOT_SYS). It is unclear why this bit was getting cleared
> as recent Hostboot versions explicitly set it to the correct value based on
> the specific system configuration. Therefore Skiboot should not alter it.
> Bit-58 (CONFIG_NVLINK_MODE) selects if NVLink mode should be enabled or
> not. Hostboot does not configure this bit so Skiboot should continue to
> configure it.
> Signed-off-by: Alistair Popple <alistair at popple.id.au>
> ---
>  hw/npu2.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Merged to master as of 0a4d0519a5a23ac11e06c3fc67fb04035716374f

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list