[Skiboot] [PATCH] npu2: Improve log output of GPU-to-link mapping

Stewart Smith stewart at linux.ibm.com
Fri Apr 20 17:22:09 AEST 2018


Reza Arbab <arbab at linux.ibm.com> writes:
> Debugging issues related to unconnected NVLinks can be a little less
> irritating if we use the NPU2DEV{DBG,INF}() macros instead of prlog().
>
> In short, change this:
>
>   NPU2: comparing GPU 'GPU2' and NPU2 'GPU1'
>   NPU2: comparing GPU 'GPU3' and NPU2 'GPU1'
>   NPU2: comparing GPU 'GPU4' and NPU2 'GPU1'
>   NPU2: comparing GPU 'GPU5' and NPU2 'GPU1'
>   	:
>   npu2_dev_bind_pci_dev: No PCI device for NPU2 device 0006:00:01.0 to bind to. If you expect a GPU to be there, this is a problem.
>
> to this:
>
>   NPU6:0:1.0 Comparing GPU 'GPU2' and NPU2 'GPU1'
>   NPU6:0:1.0 Comparing GPU 'GPU3' and NPU2 'GPU1'
>   NPU6:0:1.0 Comparing GPU 'GPU4' and NPU2 'GPU1'
>   NPU6:0:1.0 Comparing GPU 'GPU5' and NPU2 'GPU1'
>   	:
>   NPU6:0:1.0 No PCI device found for slot 'GPU1'
>
> Signed-off-by: Reza Arbab <arbab at linux.ibm.com>
> ---
>  hw/npu2.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Cheers, merged to master as of 58b1e05b08d35fcdbb4f21e89561bb4e4c3d58c0

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list