[Skiboot] [PATCH 2/2] Add SBE driver support

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Mon Apr 16 15:04:56 AEST 2018

On 04/16/2018 05:10 AM, Benjamin Herrenschmidt wrote:
> On Sun, 2018-04-15 at 14:15 +0530, Vasant Hegde wrote:
>>>> +            p9_sbe_msg_complete(sbe, msg);
>>>> +
>>>> +            /* Try to send next message */
>>>> +            p9_sbe_process_queue(sbe);
>>> Not fan of the recursion here, I would rather have a loop.
>> Its in error path. Only when first message sending fails we enter recursion to
>> send second message. Do you really want to convert this to loop?
> Yes. I want to avoid recursions. You never know what pathological case
> we'll find one day, maybe something's wrong causing the thing to error
> immediately but the completion keeps requeueing... that would blow the
> stack, which is a very bad failure mode.

Yeah. Makes sense. Will convert to loop. Thanks!


More information about the Skiboot mailing list