[Skiboot] [PATCH 2/2] npu2-opencapi: Fix 'link internal error' FIR, take 2
andrew.donnellan at au1.ibm.com
Wed Apr 11 16:55:02 AEST 2018
On 24/03/18 03:33, Frederic Barrat wrote:
> When setting up an opencapi link, we set the transport muxes first,
> then set the PHY training config register, which includes disabling
> nvlink mode for the bricks. That's the order of the init sequence, as
> found in the NPU workbook.
> In reality, doing so works, but it raises 2 FIR bits in the PowerBus
> OLL FIR Register for the 2 links when we configure the transport
> muxes. Presumably because nvlink is not disabled yet and we are
> configuring the transport muxes for opencapi.
> bit 60: link0 internal error
> bit 61: link1 internal error
> Overall the current setup ends up being correct and everything works,
> but we raise 2 FIR bits.
> So tweak the order of operations to disable nvlink before configuring
> the transport muxes. Incidentally, this is what the scripts from the
> opencapi enablement team were doing all along.
> Signed-off-by: Frederic Barrat <fbarrat at linux.vnet.ibm.com>
Acked-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com IBM Australia Limited
More information about the Skiboot