[Skiboot] [PATCH 1/2] npu2-opencapi: Fix 'link internal error' FIR, take 1

Andrew Donnellan andrew.donnellan at au1.ibm.com
Wed Apr 11 16:44:20 AEST 2018


On 24/03/18 03:33, Frederic Barrat wrote:
> When we setup a link, we always enable ODL0 and ODL1 at the same time
> in the PHY training config register, even though we are setting up
> only one OTL/ODL, so it raises a "link internal error" FIR bit in the
> PowerBus OLL FIR Register for the second link. The error is harmless,
> as we'll eventually setup the second link, but there's no reason to
> raise that FIR bit.
> 
> The fix is simply to only enable the ODL we are using for the link.
> 
> Signed-off-by: Frederic Barrat <fbarrat at linux.vnet.ibm.com>

LGTM

Acked-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list