[Skiboot] [PATCH 00/15] libffs and ffspart rework

Stewart Smith stewart at linux.ibm.com
Tue Apr 10 18:07:11 AEST 2018


Cyril Bur <cyril.bur at au1.ibm.com> writes:
> Hi,
>
> Currently the libffs api to generate TOCs is a bit
> experimental/developmental and it needs work. The original version
> abstracted too much which meant needless complexity within the
> library.
>
> I've ripped quite a lot of the complexity out of the libffs in favour
> of some added (but overall less) complexity in ffspart.
>
> Unfortunately this does change libffs just a tad, hopefully none of
> the functions have been used by anyone outside of skiboot, and the
> input file to ffspart had to change a bit too, but I haven't heard of
> anyone actually using it.
>
> This is version two of that attempt. Fundamentally they're the same
> but differences have accumulated so lets pretend this is a brand new
> unrelated attempt. I've been using it to generate pnor files within
> op-build. If you want to see that:
> https://github.com/cyrilbur-ibm/op-build/tree/ffspart it is happening
> here.
>
> I'd like to get everything upstream, so we'll start with ffspart
>
> Feedback very much welcome,

I think that this is a positive step, and seems to be all okay (once I
fix the ECC foo in core/flash.c, which I've done).

soo... series merged to master as of
c92905e1c139ac2d9cc211f51c68860589c4b656.

Let's see what breaks now!

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list