[Skiboot] [PATCH v2 0/5] libflash blocklevel ECC corrections

Stewart Smith stewart at linux.ibm.com
Tue Apr 10 16:51:12 AEST 2018

Samuel Mendoza-Jonas <sam at mendozajonas.com> writes:
> On Wed, 2018-03-07 at 17:04 +1100, Cyril Bur wrote:
>> V1 was submitted almost a year ago:
>> https://lists.ozlabs.org/pipermail/skiboot/2017-April/006977.html
>> The core of the problem still exists, this problem does still need to
>> get addressed in blocklevel rather than individually in each tool.
>> I've rebased this onto master and double checked that everything
>> still appears to work.
>> Both the gard tool and pflash built with this series have are:
>> Tested-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
>> Stewart, I'm not sure if this means we should put the tag on all
>> patches or just the last one. I've put it on the last one because
>> that makes the most sense to me.
> Reviewed-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>
> And heavily endorsed since bugs due to this were a huge pain to debug :)
> Essentially we can never turn ECC back on for NVRAM without these changes
> since the Linux kernel will try to write the lnx,oops-log partition at an
> unaligned address.

Well, we should be able to do that now.

Merged the series as of 5616c42d900afb04a4df77fe0a882f5258239211 and am
only *slightly* nervous about that :)

But hey, YOLO it's only ECC and flash, right?

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list