[Skiboot] [PATCH 2/2] phb4: Quieten and improve "Timeout waiting for electrical link"

[Michael Neuling]

On Mon, 2018-04-09 at 13:41 +1000, Benjamin Herrenschmidt wrote:
> This happens normally if a slot doesn't have a working HW presence
> detect and relies instead of inband presence detect.
> 
> The message we display is scary and not very useful unless ou
> are debugging, so quiten it up and change it to something more
> meaningful.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>


Acked-By: Michael Neuling <mikey at neuling.org>


> ---
>  hw/phb4.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/phb4.c b/hw/phb4.c
> index a716f991..531e8a62 100644
> --- a/hw/phb4.c
> +++ b/hw/phb4.c
> @@ -2646,9 +2646,8 @@ static int64_t phb4_poll_link(struct pci_slot *slot)
>  		}
>  
>  		if (slot->retries-- == 0) {
> -			PHBERR(p, "LINK: Timeout waiting for electrical link\n");
> -			PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
> -			return OPAL_HARDWARE;
> +			PHBDBG(p, "LINK: No in-band presence\n");
> +			return OPAL_SUCCESS;
>  		}
>  		/* Retry */
>  		return pci_slot_set_sm_timeout(slot, msecs_to_tb(10));