[Skiboot] [PATCH] core/lock.c: ensure valid start value for lock spin duration warning

[Stewart Smith]

Stewart Smith <stewart at linux.vnet.ibm.com> writes:
> The previous fix in a8e6cc3f4 only addressed half of the problem, as
> we could also get an invalid value for start, causing us to fail
> in a weird way.
>
> This was caught by the testcases.OpTestHMIHandling.HMI_TFMR_ERRORS
> test in op-test-framework.
>
> You'd get to this part of the test and get the erroneous lock
> spinning warnings:
>
> PATH=/usr/local/sbin:$PATH putscom -c 00000000 0x2b010a84 0003080000000000
> 0000080000000000
> [  790.140976993,4] WARNING: Lock has been spinning for 790275ms
> [  790.140976993,4] WARNING: Lock has been spinning for 790275ms
> [  790.140976918,4] WARNING: Lock has been spinning for 790275ms
>
> This patch checks the validity of timebase before setting start,
> and only checks the lock timeout if we got a valid start value.
>
> Fixes: a8e6cc3f47525f86ef1d69d69a477b6264d0f8ee
> Fixes: 84186ef0944c9413262f0974ddab3fb1343ccfe8
> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
> ---
>  core/lock.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)

Merged to master as of 36f6c25c731446d2dafa1be3b412c387259f47bd
-- 
Stewart Smith
OPAL Architect, IBM.