[Skiboot] [PATCH v2] xive: disable store EOI support

[Cédric Le Goater]

On 03/26/2018 11:50 PM, Benjamin Herrenschmidt wrote:
> On Mon, 2018-03-26 at 17:08 +0200, Cédric Le Goater wrote:
>> @@ -5027,7 +5031,7 @@ static void phb4_create(struct dt_node *np)
>>  
>>         /* Register all interrupt sources with XIVE */
>>         irq_flags = XIVE_SRC_SHIFT_BUG | XIVE_SRC_TRIGGER_PAGE;
>> -       if (p->rev >= PHB4_REV_NIMBUS_DD20)
>> +       if (PHB4_CAN_STORE_EOI(p))
>>                 irq_flags |= XIVE_SRC_STORE_EOI;
>>         xive_register_hw_source(p->base_msi, p->num_irqs - 8, 16,
>>                                 p->int_mmio, irq_flags, NULL, NULL);
> 
> Looking at this, it looks like the old code was a bit broken already...
> 
> If STORE_EOI is enabled, there is no trigger page.

Is that true for the IPIs also or only for the PHB4s interrupts ? 
I am a bit confused.

Thanks,

C.

 
> Also the shift bug only happens on DD1.0 afaik.
> 
> Cheers,
> Ben.
>