[Skiboot] [PATCH v2 2/2] npu2: hw-procedures: Add check_credits procedure

Reza Arbab arbab at linux.vnet.ibm.com
Thu Nov 23 02:54:47 AEDT 2017


On Wed, Nov 22, 2017 at 11:51:53PM +1100, Balbir Singh wrote:
>I thought this was just a debug patch, but if it goes upstream it
>should be marked for removal once the issues are resolved. I am little 
>concerned that the values we check against are not final -- are they? 
>and will not change.

I called it a "mitigator" because it makes this hardware glitch we're 
working through much easier to spot and work around out in the wild.

You're right in that once the root issue is resolved (and believe me 
when I say it's getting a lot of attention) we can walk this procedure 
back to something more benign.

In the meantime, I'm not super happy about having a "ctrl-alt-delete" 
patch out there with my name on it, but it's relieving a lot of pain.

-- 
Reza Arbab



More information about the Skiboot mailing list