[Skiboot] [PATCH v2 2/2] npu2: hw-procedures: Add check_credits procedure

Balbir Singh bsingharora at gmail.com
Wed Nov 22 23:51:53 AEDT 2017


On Wed, Nov 22, 2017 at 10:42 AM, Reza Arbab <arbab at linux.vnet.ibm.com> wrote:
> As an immediate mitigator for a current hardware glitch, add a procedure
> that can be used to validate NTL credit values. This will be called as a
> safeguard to check that link training succeeded.
>
> Assert that things are exactly as we expect, because if they aren't, the
> system will experience a catastrophic failure shortly after the start of
> link traffic.
>
> Signed-off-by: Reza Arbab <arbab at linux.vnet.ibm.com>
> ---

I thought this was just a debug patch, but if it goes upstream it
should be marked
for removal once the issues are resolved. I am little concerned that the values
we check against are not final -- are they? and will not change.

Balbir Singh.


More information about the Skiboot mailing list