[Skiboot] [PATCH] mambo: Make xscom claim to be DD 2.0

Michael Ellerman mpe at ellerman.id.au
Tue May 30 15:10:37 AEST 2017


In the mambo tcl we set the CPU version to DD 2.0, because mambo is not
bug compatible with DD 1.

But in xscom_read_cfam_chipid() we have a hard coded value, to work
around the lack of the f000f register, which claims to be P9 DD 1.0.

This doesn't seem to cause crashes or anything, but at boot we do see:

  [    0.003893084,5] XSCOM: chip 0x0 at 0x1a0000000000 [P9N DD1.0]

So fix it to claim that the xscom is also DD 2.0 to match the CPU.

Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
---
 hw/xscom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xscom.c b/hw/xscom.c
index 9fb7da6d3dcb..63813f1e81a3 100644
--- a/hw/xscom.c
+++ b/hw/xscom.c
@@ -597,7 +597,7 @@ int64_t xscom_read_cfam_chipid(uint32_t partid, uint32_t *chip_id)
 	 */
 	if (chip_quirk(QUIRK_NO_F000F)) {
 		if (proc_gen == proc_gen_p9)
-			val = 0x100D104980000000UL; /* P9 Nimbus DD1.0 */
+			val = 0x200D104980000000UL; /* P9 Nimbus DD2.0 */
 		else
 			val = 0x221EF04980000000UL; /* P8 Murano DD2.1 */
 	} else
-- 
2.7.4



More information about the Skiboot mailing list