[Skiboot] [PATCH 1/4] platforms/ibm-fsp/firenze: Fix PCI slot power-off pattern

Gavin Shan gwshan at linux.vnet.ibm.com
Tue May 30 15:54:43 AEST 2017


When powering off the PCI slot, the corresponding bits should
be set to 0bxx00xx00 instead of 0bxx11xx11. Otherwise, the
specified PCI slot can't be put into power-off state. Fortunately,
it didn't introduce any side-effects so far.

Cc: stable # 5.3.0+
Fixes: 6884fe63ba1e ("platforms/ibm-fsp: Support PCI slot")
Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
---
 platforms/ibm-fsp/firenze-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/platforms/ibm-fsp/firenze-pci.c b/platforms/ibm-fsp/firenze-pci.c
index 0a93387..828ab0f 100644
--- a/platforms/ibm-fsp/firenze-pci.c
+++ b/platforms/ibm-fsp/firenze-pci.c
@@ -836,13 +836,13 @@ static void firenze_pci_setup_power_mgt(struct pci_slot *slot,
 			plat_slot->power_status = &firenze_pci_slots[buddy].power_status;
 			plat_slot->power_mask = 0x33;
 			plat_slot->power_on   = 0x22;
-			plat_slot->power_off  = 0x33;
+			plat_slot->power_off  = 0;
 			break;
 		case 1:
 			plat_slot->power_status = &firenze_pci_slots[buddy].power_status;
 			plat_slot->power_mask = 0xcc;
 			plat_slot->power_on   = 0x88;
-			plat_slot->power_off  = 0xcc;
+			plat_slot->power_off  = 0;
 			break;
 		default:
 			prlog(PR_DEBUG, "%016llx: Invalid channel %d\n",
-- 
2.7.4



More information about the Skiboot mailing list