[Skiboot] [PATCH RFC 05/12] opal-prd: implement basic heuristic for hservice_puts loglevels

[Daniel M Crowell]

>  - all log output will go to a new log file, /var/log/opal-prd.log
>
>  - log messages of LOG_WARNING and LOG_ERROR *also* go to the standard
>    syslog paths (generally /var/log/syslog).

I'm good with that.  We just need to get PE to update their FFDC 
collection scripts to grab the new file once it shows up.


I would suggest you add a couple more cases in your compares.  We've got 
these constant in HB that are used a lot (though not all over) as the 
first 2 characters in our traces. 
#define ERR_MRK   "E>"
#define FAIL_MRK  "F>"
#define WARN_MRK  "W>"
#define INFO_MRK  "I>"


--
Dan Crowell
Senior Software Engineer - Power Systems Enablement Firmware
IBM Rochester: t/l 553-2987
dcrowell at us.ibm.com



From:   Jeremy Kerr <jk at ozlabs.org>
To:     Daniel M Crowell <dcrowell at us.ibm.com>
Cc:     skiboot at lists.ozlabs.org, Frederic Bonnard <FREDERIC at fr.ibm.com>
Date:   06/02/2017 10:15 PM
Subject:        Re: [PATCH RFC 05/12] opal-prd: implement basic heuristic 
for hservice_puts loglevels



Hi Dan,

> So what will the actual result of these changes be?  Is this going to
> change where our messages show up?

This only changes the priority of the messages logged. Currently, we log
all HBRT output at LOG_INFO priority. After this change, we will log
HBRT messages that contain the string "error" as LOG_ERROR and those
that contain "warn" as LOG_WARNING (both are higher priorities than
LOG_INFO).

So, nothing will change in terms of log locations at this stage.

However, once this is done, I'd like to propose a second change, to the
distributions' packing of opal-prd. The idea would be that:

  - all log output will go to a new log file, /var/log/opal-prd.log

  - log messages of LOG_WARNING and LOG_ERROR *also* go to the standard
    syslog paths (generally /var/log/syslog).

This means that we get all the HBRT output stored, but only include
higher-priority messages in the standard system logs.

How does that sound?

Cheers,


Jeremy





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20170602/e0804949/attachment.html>