[Skiboot] [PATCH RFC 05/12] opal-prd: implement basic heuristic for hservice_puts loglevels

[Jeremy Kerr]

Hi Dan,

> So what will the actual result of these changes be?  Is this going to
> change where our messages show up?

This only changes the priority of the messages logged. Currently, we log
all HBRT output at LOG_INFO priority. After this change, we will log
HBRT messages that contain the string "error" as LOG_ERROR and those
that contain "warn" as LOG_WARNING (both are higher priorities than
LOG_INFO).

So, nothing will change in terms of log locations at this stage.

However, once this is done, I'd like to propose a second change, to the
distributions' packing of opal-prd. The idea would be that:

  - all log output will go to a new log file, /var/log/opal-prd.log

  - log messages of LOG_WARNING and LOG_ERROR *also* go to the standard
    syslog paths (generally /var/log/syslog).

This means that we get all the HBRT output stored, but only include
higher-priority messages in the standard system logs.

How does that sound?

Cheers,


Jeremy