[Skiboot] [PATCH V2 4/6] chiptod: Sync timebase in both CAPP units on Naples

Stewart Smith stewart at linux.vnet.ibm.com
Thu Feb 25 15:50:42 AEDT 2016


Philippe Bergheaud <felix at linux.vnet.ibm.com> writes:
> diff --git a/hw/phb3.c b/hw/phb3.c
> index 30088c5..76fa1cc 100644
> --- a/hw/phb3.c
> +++ b/hw/phb3.c
> @@ -3515,7 +3515,7 @@ static int64_t phb3_set_capi_mode(struct phb *phb, uint64_t mode,
>
>  	phb3_init_capp_regs(p);
>
> -	if (!chiptod_capp_timebase_sync(p->chip_id)) {
> +	if (!chiptod_capp_timebase_sync(p->chip_id, reg_offset)) {
>  		PHBERR(p, "CAPP: Failed to sync timebase\n");
>  		return OPAL_HARDWARE;
>  	}

Any reason we can't pass down struct phb instead and be a bit clearer
about what we're doing, and not really depend on there always being an offset?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list